Skip to content

Changes to data structures to fix bugs: issue #6#7

Open
tomcostello wants to merge 11 commits intoOperationCode:masterfrom
tomcostello:master
Open

Changes to data structures to fix bugs: issue #6#7
tomcostello wants to merge 11 commits intoOperationCode:masterfrom
tomcostello:master

Conversation

@tomcostello
Copy link

I noticed some bugs in the implementations of the first few data structures in the algorithms course. In LinkedList.js the tail was not set if the element added was the last element. In Queue peek should look at the last element of the array, the next one to be popped, not the first element. In Queue, one of the tests was wrong, as the elements are stored in the reverse order in which they are added, as they are pushed on the front using unshift.

The one arguable change is in Stack.js where I think the return code should be null, when you pop or peek and empty stack, but I suppose some people could think the opposite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant